[ https://issues.apache.org/jira/browse/HDFS-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816384#comment-13816384 ]
Hudson commented on HDFS-5468: ------------------------------ SUCCESS: Integrated in Hadoop-trunk-Commit #4702 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4702/]) HDFS-5468. CacheAdmin help command does not recognize commands (Stephen Chu via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1539786) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml > CacheAdmin help command does not recognize commands > --------------------------------------------------- > > Key: HDFS-5468 > URL: https://issues.apache.org/jira/browse/HDFS-5468 > Project: Hadoop HDFS > Issue Type: Bug > Components: tools > Affects Versions: 3.0.0, 2.3.0 > Reporter: Stephen Chu > Assignee: Stephen Chu > Priority: Minor > Fix For: 3.0.0 > > Attachments: HDFS-5468.patch > > > Currently, the hdfs cacheadmin -help command will not recognize correct > command inputs: > {code} > [hdfs@hdfs-cache ~]# hdfs cacheadmin -help listPools > Sorry, I don't know the command 'listPools'. > Valid command names are: > -addDirective, -removeDirective, -removeDirectives, -listDirectives, > -addPool, -modifyPool, -removePool, -listPools, -help > [hdfs@hdfs-cache ~]# hdfs cacheadmin -help -listPools > Sorry, I don't know the command 'listPools'. > Valid command names are: > -addDirective, -removeDirective, -removeDirectives, -listDirectives, > -addPool, -modifyPool, -removePool, -listPools, -help > {code} > In the code, we strip the input command of leading hyphens, but then compare > it to the command names, which are all prefixed by a hyphen. > Also, cacheadmin -removeDirectives requires specifying a path with -path but > -path is not shown in the usage. We should fix this as well. -- This message was sent by Atlassian JIRA (v6.1#6144)