[
https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831796#comment-13831796
]
Jing Zhao commented on HDFS-5538:
---------------------------------
The patch looks pretty good to me. Some comments:
# nit: In EditLogInputStream#fromUrl, please update the javadoc (add description
about the new parameter) and fix the indentation.
# Please post some testing results for HA setup (to cover the changes in
EditLogFileInputStream and QuorumJournalManager) when https is enabled.
# It will be better to update the jira description to provide details about how
the patch "eases the handling of HTTPS connections" (e.g., loading the SSL
factory
setup in the beginning, and getting rid of its dependency of the global
configuration HttpConfig when determining whether we need to setup an ssl
connection).
> URLConnectionFactory should pick up the SSL related configuration by default
> ----------------------------------------------------------------------------
>
> Key: HDFS-5538
> URL: https://issues.apache.org/jira/browse/HDFS-5538
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch,
> HDFS-5538.002.patch
>
>
> The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does
> not pick up any hadoop-specific, SSL-related configuration. Its customers
> have to set up the ConnectionConfigurator explicitly in order to pick up
> these configurations.
> This is less than ideal for HTTPS because whenever the code needs to make a
> HTTPS connection, the code is forced to go through the set up.
> This jira refactors URLConnectionFactory to ease the handling of HTTPS
> connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
