[ https://issues.apache.org/jira/browse/HDFS-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832134#comment-13832134 ]
Hadoop QA commented on HDFS-5538: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615686/HDFS-5538.003.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5562//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5562//console This message is automatically generated. > URLConnectionFactory should pick up the SSL related configuration by default > ---------------------------------------------------------------------------- > > Key: HDFS-5538 > URL: https://issues.apache.org/jira/browse/HDFS-5538 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-5538.000.patch, HDFS-5538.001.patch, > HDFS-5538.002.patch, HDFS-5538.003.patch > > > The default instance of URLConnectionFactory, DEFAULT_CONNECTION_FACTORY does > not pick up any hadoop-specific, SSL-related configuration. Its customers > have to set up the ConnectionConfigurator explicitly in order to pick up > these configurations. This is less than ideal for HTTPS because whenever the > code needs to make a HTTPS connection, the code is forced to go through the > set up. > This jira refactors URLConnectionFactory to ease the handling of HTTPS > connections (compared to the DEFAULT_CONNECTION_FACTORY we have right now). > In particular, instead of loading the SSL configurator statically in > SecurityUtil (based on a global configuration about SSL), and determine > whether we should set up SSL for a given connection based on whether the SSL > configurator is null, we now load the SSL configurator in > URLConnectionFactory, and determine if we need to use the configurator to set > up an SSL connection based on if the given URL/connection is https. -- This message was sent by Atlassian JIRA (v6.1#6144)