[ 
https://issues.apache.org/jira/browse/HDFS-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841927#comment-13841927
 ] 

Jing Zhao commented on HDFS-5023:
---------------------------------

Thanks Mit! Your explanation is very helpful. 

So since the current patch deletes snapshot for every test case, how about 
always using the same snapshot name, and moving "delete-snapshot" and 
"disallow-snapshot" code to an "After" method? This can make the code more 
clean.

> TestSnapshotPathINodes.testAllowSnapshot is failing in branch-2
> ---------------------------------------------------------------
>
>                 Key: HDFS-5023
>                 URL: https://issues.apache.org/jira/browse/HDFS-5023
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots, test
>    Affects Versions: 2.4.0
>            Reporter: Ravi Prakash
>            Assignee: Mit Desai
>              Labels: test
>         Attachments: HDFS-5023.patch, HDFS-5023.patch, HDFS-5023.patch, 
> TEST-org.apache.hadoop.hdfs.server.namenode.TestSnapshotPathINodes.xml, 
> org.apache.hadoop.hdfs.server.namenode.TestSnapshotPathINodes-output.txt
>
>
> The assertion on line 91 is failing. I am using Fedora 19 + JDK7. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to