[ 
https://issues.apache.org/jira/browse/HDFS-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843287#comment-13843287
 ] 

Mit Desai commented on HDFS-5023:
---------------------------------

Jing,
I have tried making the changes according your suggestion. That would work but 
this will cause problem with the two tests i) testAllowSnapshot ii) 
testNonSnapshotPathINodes.
-These two tests does not create snapshots, so moving the "disallowSnapshot" 
and "deleteSnapshot" lines to "After" method, will throw an exception after 
their completion.

-As a fix to that, we will have to create an unnecessary snapshot after these 
tests.
-Or another fix would be to place the "disallowSnapshot" and "deleteSnapshot" 
lines in a try block and we don't do anything in the catch block ( This is just 
an additional option. But it does not seem to be good choice to me ).

But, I think that none of these solutions can be good to go. What do you think?

> TestSnapshotPathINodes.testAllowSnapshot is failing in branch-2
> ---------------------------------------------------------------
>
>                 Key: HDFS-5023
>                 URL: https://issues.apache.org/jira/browse/HDFS-5023
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots, test
>    Affects Versions: 2.4.0
>            Reporter: Ravi Prakash
>            Assignee: Mit Desai
>              Labels: test
>         Attachments: HDFS-5023.patch, HDFS-5023.patch, HDFS-5023.patch, 
> TEST-org.apache.hadoop.hdfs.server.namenode.TestSnapshotPathINodes.xml, 
> org.apache.hadoop.hdfs.server.namenode.TestSnapshotPathINodes-output.txt
>
>
> The assertion on line 91 is failing. I am using Fedora 19 + JDK7. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to