[ 
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5594:
--------------------------------

    Attachment: HDFS-5594.4.patch

Here is version 4 of the patch with following changes:
# {{equals}} and {{hashCode}} methods have switched from Commons Lang to Guava.
# {{Acl#entries}} is converted from {{Set}} to {{List}}.  Let's go with that, 
and the NameNode implementation can still enforce the unique constraint that I 
mentioned.
# I implemented {{AclEntry#compareTo}} and sorted the entries on the way out of 
{{Acl#Builder}}.  I added another test for this.

Haohui, the only trailing whitespace I saw was in the diff context for existing 
code, not the new code.  {{ViewFileSystem}} has a lot of trailing whitepsace 
right now, and I'd prefer not to roll a full cleanup into this patch.  If you 
see trailing whitespace elsewhere in the new code, please let me know.


> FileSystem API for ACLs.
> ------------------------
>
>                 Key: HDFS-5594
>                 URL: https://issues.apache.org/jira/browse/HDFS-5594
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5594.1.patch, HDFS-5594.2.patch, HDFS-5594.3.patch, 
> HDFS-5594.4.patch
>
>
> Add new methods to {{FileSystem}} for manipulating ACLs.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to