[ 
https://issues.apache.org/jira/browse/HDFS-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HDFS-5594:
--------------------------------

    Attachment: HDFS-5594.7.patch

Thanks, Nicholas.  I'm uploading patch version 7.  I plan to commit this 
version to the HDFS-4685 branch tomorrow unless there is more feedback by then.

bq. In FileSystem, should modifyAclEntries be called as addAclEntries?

This method actually merges the requested modifications into the file's 
existing ACL.  The aclSpec can contain a mix of adding new ACL entries and 
modifying the permissions associated with existing ACL entries.  If the file 
has existing ACL entries that are not mentioned in the aclSpec, then those 
entries are retained.  I think {{modifyAclEntries}} is the appropriate name, 
but I also think my JavaDocs didn't explain this clearly enough.  I've tried to 
improve on this in the new patch.

bq. Typo in Acl: associatd

Thanks for catching this.  I fixed it.

> FileSystem API for ACLs.
> ------------------------
>
>                 Key: HDFS-5594
>                 URL: https://issues.apache.org/jira/browse/HDFS-5594
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5594.1.patch, HDFS-5594.2.patch, HDFS-5594.3.patch, 
> HDFS-5594.4.patch, HDFS-5594.5.patch, HDFS-5594.6.patch, HDFS-5594.7.patch
>
>
> Add new methods to {{FileSystem}} for manipulating ACLs.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to