[ 
https://issues.apache.org/jira/browse/HDFS-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845057#comment-13845057
 ] 

Hadoop QA commented on HDFS-5647:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12618161/HDFS-5647.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
                  
org.apache.hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
                  org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
                  org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot
                  org.apache.hadoop.hdfs.server.namenode.TestSnapshotPathINodes

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5692//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5692//console

This message is automatically generated.

> Merge INodeDirectory.Feature and INodeFile.Feature
> --------------------------------------------------
>
>                 Key: HDFS-5647
>                 URL: https://issues.apache.org/jira/browse/HDFS-5647
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5647.000.patch, HDFS-5647.001.patch, 
> HDFS-5647.002.patch
>
>
> HDFS-4685 implements ACLs for HDFS, which can benefit from the INode features 
> introduced in HDFS-5284. The current code separates the INode feature of 
> INodeFile and INodeDirectory into two different class hierarchies. This 
> hinders the implementation of ACL since ACL is a concept that applies to both 
> INodeFile and INodeDirectory.
> This jira proposes to merge the two class hierarchies (i.e., 
> INodeDirectory.Feature and INodeFile.Feature) to simplify the implementation 
> of ACLs.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to