[ https://issues.apache.org/jira/browse/HDFS-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845751#comment-13845751 ]
Colin Patrick McCabe commented on HDFS-5634: -------------------------------------------- bq. DirectBufferPool, would it be better to use a Deque's stack operations rather than a Queue? Might give better cache locality to do LIFO rather than FIFO. I examined this code more carefully, and I found that it was actually using LIFO at the moment. The reason is because it uses {{ConcurrentLinkedQueue#add}} to add the elements, which add them to the end. It then uses {{ConcurrentLinkedQueue#poll}} to get the elements, which gets them from the beginning. > allow BlockReaderLocal to switch between checksumming and not > ------------------------------------------------------------- > > Key: HDFS-5634 > URL: https://issues.apache.org/jira/browse/HDFS-5634 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Affects Versions: 3.0.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-5634.001.patch, HDFS-5634.002.patch > > > BlockReaderLocal should be able to switch between checksumming and > non-checksumming, so that when we get notifications that something is mlocked > (see HDFS-5182), we can avoid checksumming when reading from that block. -- This message was sent by Atlassian JIRA (v6.1.4#6159)