[
https://issues.apache.org/jira/browse/HDFS-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847945#comment-13847945
]
Colin Patrick McCabe commented on HDFS-5634:
--------------------------------------------
I addressed the stuff discussed above. I also addressed the case where there
are no checksums for the block. This can lead to some weird conditions like
bytesPerChecksum being 0, so we want to avoid dividing by this number before we
check it. This patch also sets the skipChecksum boolean when it detects one of
these blocks, which should speed things up. This is an optimization that the
old code didn't do.
BlockReaderLocalTest is now an abstract class rather than an interface, so that
we can have defaults. I added a bunch of new tests, including one where we set
readahead just less than the block size.
> allow BlockReaderLocal to switch between checksumming and not
> -------------------------------------------------------------
>
> Key: HDFS-5634
> URL: https://issues.apache.org/jira/browse/HDFS-5634
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5634.001.patch, HDFS-5634.002.patch,
> HDFS-5634.003.patch, HDFS-5634.004.patch, HDFS-5634.005.patch
>
>
> BlockReaderLocal should be able to switch between checksumming and
> non-checksumming, so that when we get notifications that something is mlocked
> (see HDFS-5182), we can avoid checksumming when reading from that block.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
