[ https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847897#comment-13847897 ]
Colin Patrick McCabe commented on HDFS-5665: -------------------------------------------- I agree-- I think it would be fine to initialize this without holding the writeLock. > Remove the unnecessary writeLock while initializing CacheManager in > FsNameSystem Ctor > ------------------------------------------------------------------------------------- > > Key: HDFS-5665 > URL: https://issues.apache.org/jira/browse/HDFS-5665 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Affects Versions: 3.0.0, 2.2.0 > Reporter: Uma Maheswara Rao G > Assignee: Uma Maheswara Rao G > > I just saw the below piece of code in Fsnamesystem ctor. > {code} > writeLock(); > try { > this.cacheManager = new CacheManager(this, conf, blockManager); > } finally { > writeUnlock(); > } > {code} > It seems unnecessary to keep writeLock here. I am not sure if there is a > clear reason to keep the lock. -- This message was sent by Atlassian JIRA (v6.1.4#6159)