[
https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850536#comment-13850536
]
Hudson commented on HDFS-5665:
------------------------------
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1641 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1641/])
HDFS-5665. Remove the unnecessary writeLock while initializing CacheManager in
FsNameSystem Ctor. (Uma Maheswara Rao G via Andrew Wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551270)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Remove the unnecessary writeLock while initializing CacheManager in
> FsNameSystem Ctor
> -------------------------------------------------------------------------------------
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0
>
> Attachments: HDFS-5665.patch
>
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a
> clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
