[ https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875809#comment-13875809 ]
Andrew Wang commented on HDFS-5709: ----------------------------------- Thanks for the review Jing, new patch addresses most of your comments except as follows: * I made the methods pass a String rather than a FSN. I think adding generic methods and image and edit wrappers is a little overkill right now, so I'd like to do that when we actually want to do this renaming for another reserved path. Should be straightforward. * I put a check with DFSUtil#isValidName when renaming a path. For image loading, it's mostly dealing with inodes and single path components, so I added another DFSUtil that should cover that. > Improve upgrade with existing files and directories named ".snapshot" > --------------------------------------------------------------------- > > Key: HDFS-5709 > URL: https://issues.apache.org/jira/browse/HDFS-5709 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Affects Versions: 3.0.0, 2.2.0 > Reporter: Andrew Wang > Assignee: Andrew Wang > Labels: snapshots, upgrade > Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch > > > Right now in trunk, upgrade fails messily if the old fsimage or edits refer > to a directory named ".snapshot". We should at least print a better error > message (which I believe was the original intention in HDFS-4666), and [~atm] > proposed automatically renaming these files and directories. -- This message was sent by Atlassian JIRA (v6.1.5#6160)