[ 
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877759#comment-13877759
 ] 

Suresh Srinivas commented on HDFS-5709:
---------------------------------------

bq. I don't think we should be introducing another startup option for this, 
mostly because I can't imagine a user not wanting to automatically rename files 
that use names that are now reserved. 
One of the requirements we considered is, the files should not be renamed 
silently. Hence the start up option that a user must pass. This is the same 
reason why we invented configuration option as well.

Most of the time this option is not necessary (true with configuration as 
well). But we could fail the namenode upgrade by indicating "upgrade must be 
performed with rename flag because the reserved file names are used...". Only a 
very small set of users will hit this issue and will have to start the upgrade 
again with -rename_reserved_names flag.

> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
>                 Key: HDFS-5709
>                 URL: https://issues.apache.org/jira/browse/HDFS-5709
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: snapshots, upgrade
>         Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch, 
> hdfs-5709-4.patch, hdfs-5709-5.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer 
> to a directory named ".snapshot". We should at least print a better error 
> message (which I believe was the original intention in HDFS-4666), and [~atm] 
> proposed automatically renaming these files and directories.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to