[ 
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877044#comment-13877044
 ] 

Andrew Wang commented on HDFS-5709:
-----------------------------------

Hi Suresh, could you lay out your alternative proposal for a conf option? I 
could rename the conf and make it so it takes a delimited set of kv pairs, e.g. 
".snapshot=.user-snapshot,.some-new-reserved=.renamed-new-reserved", but I felt 
that was kind of ugly. I wanted full sub rather than prefix here for 
flexibility.

I also honestly don't think there will be that many more, if any, reserved path 
components in the future. I'm trying to dig up some listing of reserved paths 
in other FSs as a guide, but I'm coming up dry besides 
http://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words which has 
the definitely quirky behavior of FAT and NTFS, and obviously WAFL's .snapshot.

> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
>                 Key: HDFS-5709
>                 URL: https://issues.apache.org/jira/browse/HDFS-5709
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: snapshots, upgrade
>         Attachments: hdfs-5709-1.patch, hdfs-5709-2.patch, hdfs-5709-3.patch, 
> hdfs-5709-4.patch, hdfs-5709-5.patch
>
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer 
> to a directory named ".snapshot". We should at least print a better error 
> message (which I believe was the original intention in HDFS-4666), and [~atm] 
> proposed automatically renaming these files and directories.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to