[ 
https://issues.apache.org/jira/browse/HDFS-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886992#comment-13886992
 ] 

Chris Nauroth commented on HDFS-5614:
-------------------------------------

I've just noticed that my v1 patch here has introduced a bug.  If I 1) apply an 
ACL to a file, 2) remove that ACL, 3) save a new checkpoint, and 4) restart NN, 
I find that I can no longer add a new ACL to that file.  Somehow, the file has 
been left in a state where the ACL bit is off, but it has an {{AclFeature}}.  
Then, when I try to add an ACL again, it trips the {{IllegalStateException}} 
for trying to add multiple instances of {{AclFeature}} in 
{{INodeWithAdditionalFields#addAclFeature}}.

I'm going to track down this bug.  I suspect this patch will remain mostly the 
same, but I wanted to give potential code reviewers a heads-up that there will 
be a v2 patch coming.

> NameNode: implement handling of ACLs in combination with snapshots.
> -------------------------------------------------------------------
>
>                 Key: HDFS-5614
>                 URL: https://issues.apache.org/jira/browse/HDFS-5614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5614.1.patch
>
>
> Within a snapshot, all ACLs are frozen at the moment that the snapshot was 
> created.  ACL changes in the parent of the snapshot are not applied to the 
> snapshot.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to