[ 
https://issues.apache.org/jira/browse/HDFS-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888236#comment-13888236
 ] 

Chris Nauroth commented on HDFS-5614:
-------------------------------------

bq. Or we can pass in a Feature.class array here?

I actually had the same thought and tried that out before posting v3.  
Unfortunately, it has the same problem, because 
{{INodeWithAdditionalFields#getFeature}} is protected too.  It seems we have to 
widen visibility on some level to make this work.  This isn't on a 
client-facing boundary though, so at least it's all in code isolated to the 
NameNode.

Anyway, thank you for the excellent code review and for catching a few bugs.  
I'll commit v3.

> NameNode: implement handling of ACLs in combination with snapshots.
> -------------------------------------------------------------------
>
>                 Key: HDFS-5614
>                 URL: https://issues.apache.org/jira/browse/HDFS-5614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS ACLs (HDFS-4685)
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-5614.1.patch, HDFS-5614.2.patch, HDFS-5614.3.patch
>
>
> Within a snapshot, all ACLs are frozen at the moment that the snapshot was 
> created.  ACL changes in the parent of the snapshot are not applied to the 
> snapshot.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to