[ https://issues.apache.org/jira/browse/HDFS-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900024#comment-13900024 ]
Hadoop QA commented on HDFS-3969: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628622/hdfs-3969-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. See https://builds.apache.org/job/PreCommit-HDFS-Build/6132//artifact/trunk/patchprocess/diffJavadocWarnings.txt for details. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDistributedFileSystem {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6132//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6132//console This message is automatically generated. > Small bug fixes and improvements for disk locations API > ------------------------------------------------------- > > Key: HDFS-3969 > URL: https://issues.apache.org/jira/browse/HDFS-3969 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Affects Versions: 2.3.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-3969-2.patch, hdfs-3969.txt > > > The new disk block locations API has a configurable timeout, but it's used > inconsistently: the invokeAll() call to the thread pool assumes the timeout > is in seconds, but the RPC timeout is set in milliseconds. > Also, we can improve the wire protocol for this API to be a lot more > efficient. -- This message was sent by Atlassian JIRA (v6.1.5#6160)