[ 
https://issues.apache.org/jira/browse/HDFS-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911285#comment-13911285
 ] 

Aaron T. Myers commented on HDFS-3969:
--------------------------------------

+1, the patch looks good to me. My only suggestion is that you might consider 
actually deprecating the former config setting name, but up to you.

> Small bug fixes and improvements for disk locations API
> -------------------------------------------------------
>
>                 Key: HDFS-3969
>                 URL: https://issues.apache.org/jira/browse/HDFS-3969
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.3.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-3969-2.patch, hdfs-3969-3.patch, hdfs-3969.txt
>
>
> The new disk block locations API has a configurable timeout, but it's used 
> inconsistently: the invokeAll() call to the thread pool assumes the timeout 
> is in seconds, but the RPC timeout is set in milliseconds.
> Also, we can improve the wire protocol for this API to be a lot more 
> efficient.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to