[ https://issues.apache.org/jira/browse/HDFS-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912479#comment-13912479 ]
Haohui Mai commented on HDFS-5908: ---------------------------------- Looks good to me. +1 pending Jenkins. I wonder, do you have any plans to make similar changes on the methods in {{AclTransformation}}? I think it can be addressed in a separate jira though. > Change AclFeature to capture list of ACL entries in an ImmutableList. > --------------------------------------------------------------------- > > Key: HDFS-5908 > URL: https://issues.apache.org/jira/browse/HDFS-5908 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Affects Versions: 3.0.0 > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Minor > Attachments: HDFS-5908.1.patch > > > After an {{AclFeature}} has been attached to an inode, its ACL entries must > be immutable. We can enforce this in the type system more strongly by > storing the entries in an {{ImmutableList}} and changing the getter to return > that type instead of raw {{List}}. -- This message was sent by Atlassian JIRA (v6.1.5#6160)