[ https://issues.apache.org/jira/browse/HDFS-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912504#comment-13912504 ]
Hadoop QA commented on HDFS-5908: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631115/HDFS-5908.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6240//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6240//console This message is automatically generated. > Change AclFeature to capture list of ACL entries in an ImmutableList. > --------------------------------------------------------------------- > > Key: HDFS-5908 > URL: https://issues.apache.org/jira/browse/HDFS-5908 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Affects Versions: 3.0.0 > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Minor > Attachments: HDFS-5908.1.patch > > > After an {{AclFeature}} has been attached to an inode, its ACL entries must > be immutable. We can enforce this in the type system more strongly by > storing the entries in an {{ImmutableList}} and changing the getter to return > that type instead of raw {{List}}. -- This message was sent by Atlassian JIRA (v6.1.5#6160)