[ https://issues.apache.org/jira/browse/HDFS-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080645#comment-14080645 ]
Uma Maheswara Rao G commented on HDFS-6787: ------------------------------------------- Make sense to me. +1 patch looks good to me. Did you verify that inodes cleaned properly by debug points or so? I assume, yes. Pls comment. > Remove duplicate code in FSDirectory#unprotectedConcat > ------------------------------------------------------ > > Key: HDFS-6787 > URL: https://issues.apache.org/jira/browse/HDFS-6787 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.0.0 > Reporter: Yi Liu > Assignee: Yi Liu > Attachments: HDFS-6787.001.patch > > > {code} > // update inodeMap > removeFromInodeMap(Arrays.asList(allSrcInodes)); > {code} > this snippet of code is duplicate, since we already have the logic above it: > {code} > for(INodeFile nodeToRemove: allSrcInodes) { > if(nodeToRemove == null) continue; > > nodeToRemove.setBlocks(null); > trgParent.removeChild(nodeToRemove, trgLatestSnapshot); > inodeMap.remove(nodeToRemove); > count++; > } > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)