[
https://issues.apache.org/jira/browse/HDFS-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086097#comment-14086097
]
Hudson commented on HDFS-6787:
------------------------------
FAILURE: Integrated in Hadoop-Yarn-trunk #634 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/634/])
HDFS-6787. Remove duplicate code in FSDirectory#unprotectedConcat. Contributed
by Yi Liu. (umamahesh:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1615622)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
> Remove duplicate code in FSDirectory#unprotectedConcat
> ------------------------------------------------------
>
> Key: HDFS-6787
> URL: https://issues.apache.org/jira/browse/HDFS-6787
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Yi Liu
> Assignee: Yi Liu
> Fix For: 3.0.0, 2.6.0
>
> Attachments: HDFS-6787.001.patch
>
>
> {code}
> // update inodeMap
> removeFromInodeMap(Arrays.asList(allSrcInodes));
> {code}
> this snippet of code is duplicate, since we already have the logic above it:
> {code}
> for(INodeFile nodeToRemove: allSrcInodes) {
> if(nodeToRemove == null) continue;
>
> nodeToRemove.setBlocks(null);
> trgParent.removeChild(nodeToRemove, trgLatestSnapshot);
> inodeMap.remove(nodeToRemove);
> count++;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
