[ https://issues.apache.org/jira/browse/HDFS-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102178#comment-14102178 ]
Uma Maheswara Rao G commented on HDFS-6870: ------------------------------------------- This is Good Catch Yi! Please post the fix. > Blocks and INodes could leak for Rename with overwrite flag > ----------------------------------------------------------- > > Key: HDFS-6870 > URL: https://issues.apache.org/jira/browse/HDFS-6870 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Yi Liu > Assignee: Yi Liu > > Following code in FSDirectory#unprotectedRenameTo doesn't collect blocks and > INodes for non snapshot path. > {code} > if (removedDst != null) { > undoRemoveDst = false; > if (removedNum > 0) { > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List<INode> removedINodes = new ChunkedArrayList<INode>(); > filesDeleted = removedDst.cleanSubtree(Snapshot.CURRENT_STATE_ID, > dstIIP.getLatestSnapshotId(), collectedBlocks, removedINodes, > true).get(Quota.NAMESPACE); > getFSNamesystem().removePathAndBlocks(src, collectedBlocks, > removedINodes, false); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)