[ https://issues.apache.org/jira/browse/HDFS-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104328#comment-14104328 ]
Hudson commented on HDFS-6870: ------------------------------ FAILURE: Integrated in Hadoop-trunk-Commit #6089 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6089/]) HDFS-6870. Blocks and INodes could leak for Rename with overwrite flag. Contributed by Yi Liu. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1619192) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRename.java > Blocks and INodes could leak for Rename with overwrite flag > ----------------------------------------------------------- > > Key: HDFS-6870 > URL: https://issues.apache.org/jira/browse/HDFS-6870 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Yi Liu > Assignee: Yi Liu > Fix For: 2.6.0 > > Attachments: HDFS-6870.001.patch > > > Following code in FSDirectory#unprotectedRenameTo doesn't collect blocks and > INodes for non snapshot path. > {code} > if (removedDst != null) { > undoRemoveDst = false; > if (removedNum > 0) { > BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo(); > List<INode> removedINodes = new ChunkedArrayList<INode>(); > filesDeleted = removedDst.cleanSubtree(Snapshot.CURRENT_STATE_ID, > dstIIP.getLatestSnapshotId(), collectedBlocks, removedINodes, > true).get(Quota.NAMESPACE); > getFSNamesystem().removePathAndBlocks(src, collectedBlocks, > removedINodes, false); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)