[
https://issues.apache.org/jira/browse/HDFS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107936#comment-14107936
]
Hadoop QA commented on HDFS-6902:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12663829/HDFS-6902.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestEditLog
org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7736//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7736//console
This message is automatically generated.
> FileWriter should be closed in finally block in BlockReceiver#receiveBlock()
> ----------------------------------------------------------------------------
>
> Key: HDFS-6902
> URL: https://issues.apache.org/jira/browse/HDFS-6902
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HDFS-6902.1.patch
>
>
> Here is code starting from line 828:
> {code}
> try {
> FileWriter out = new FileWriter(restartMeta);
> // write out the current time.
> out.write(Long.toString(Time.now() + restartBudget));
> out.flush();
> out.close();
> } catch (IOException ioe) {
> {code}
> If write() or flush() call throws IOException, out wouldn't be closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
