[ https://issues.apache.org/jira/browse/HDFS-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111035#comment-14111035 ]
Colin Patrick McCabe commented on HDFS-6902: -------------------------------------------- +1. thanks > FileWriter should be closed in finally block in BlockReceiver#receiveBlock() > ---------------------------------------------------------------------------- > > Key: HDFS-6902 > URL: https://issues.apache.org/jira/browse/HDFS-6902 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ted Yu > Assignee: Tsuyoshi OZAWA > Priority: Minor > Attachments: HDFS-6902.1.patch, HDFS-6902.2.patch > > > Here is code starting from line 828: > {code} > try { > FileWriter out = new FileWriter(restartMeta); > // write out the current time. > out.write(Long.toString(Time.now() + restartBudget)); > out.flush(); > out.close(); > } catch (IOException ioe) { > {code} > If write() or flush() call throws IOException, out wouldn't be closed. -- This message was sent by Atlassian JIRA (v6.2#6252)