[ https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153070#comment-14153070 ]
Masatake Iwasaki commented on HDFS-7055: ---------------------------------------- Setting hadoop.trace.sampler=ProbabilitySampler did not reduce the number of spans above because Trace#startSpan always start span without regarding to sampler when there is ongoing trace. {code} public static TraceScope startSpan(String description, Sampler<TraceInfo> s, TraceInfo tinfo) { Span span = null; if (isTracing() || s.next(tinfo)) { span = new MilliSpan(description, tinfo.traceId, tinfo.spanId, ... {code} I would like guard for this situation. > Add tracing to DFSInputStream > ----------------------------- > > Key: HDFS-7055 > URL: https://issues.apache.org/jira/browse/HDFS-7055 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Affects Versions: 2.6.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch, > HDFS-7055.004.patch, screenshot-get-1mb.png > > > Add tracing to DFSInputStream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)