[ https://issues.apache.org/jira/browse/HDFS-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153744#comment-14153744 ]
stack commented on HDFS-7055: ----------------------------- bq. I think SpanReceiverHost#getUniqueLocalTraceFileName is useful but it should belong to htrace. So, if no receiver set up, traces go nowhere? To see anything, you'd have to load a receiver with the just-added trace command (i.e.HDFS-6956)? If so, that seems cleaner. The alternative where files show up in /tmp if no receiver is set is less so. Drop this facility from this patch? On the patch, are these defined anywhere "NeverSampler"? Should we make it so they are? Or should they be toString of the enums? Otherwise, the patch looks good to me caveat the interjection you and Masatake are figuring. Good stuff. > Add tracing to DFSInputStream > ----------------------------- > > Key: HDFS-7055 > URL: https://issues.apache.org/jira/browse/HDFS-7055 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Affects Versions: 2.6.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-7055.002.patch, HDFS-7055.003.patch, > HDFS-7055.004.patch, screenshot-get-1mb.png > > > Add tracing to DFSInputStream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)