Hi Adam,

On 08/08/2012 07:55 PM, Adam Hraska wrote:
> I have been keeping quite busy during week 11:

Me too, I even managed to reduce the backlog of reading your changesets
to 12, but then you started committing again :-)

> 1) I added plenty of benchmarks for CHT. Run "chtbench
> 0 0 0" in the kernel console for the cht-bench branch [1].
> 
> 2) I ran the benchmarks and made sure the results were
> statistically significant. Performance graphs are here:
> http://trac.helenos.org/wiki/ConcurrentHashTable#Results

Pretty impressive. Nice wiki article, btw.

> 4) More recently, I cleaned up the single threaded user
> space hash table [4]:
> - Keys are now represented as void* instead of the cumbersome
>   unsigned long[].

I also liked the change which changes the API towards computing the hash
from the (inserted) items rather than from an external array holding the
keys.

> - All hashes computed from multiple values use hash_combine()
>   instead of ad hoc solutions.

Great.

> - Replaced partial matching hash_table_remove() with
>   hash_table_apply().

Ok.

Keep up the good work, I will do some more code reading before the camp.

Jakub

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to