Hi MaaSTaaR,
thanks a lot for your patch! I've read through it and it looks pretty
reasonable. Use of Arabic obviously has limitations since we cannot render
RTL text or do complex text layout, still it is very nice to have keyboard
layout for some non-latin-based script. I have some comments below.
A small nit, as it seems Caps shift is not used on Arabic keyboard (there is
no upper/lower case), you changed map_ucase/map_lcase to behave exactly like
map_shifted / map_unshifted. It might be better just to move the contents of
map_ucase to map_shifted and map_lcase to map_unshifted and remove map_
ucase/map_lcase altogether.
I also compared your implementation with how arabic layout works in GNOME/
Solaris (did not try else yet). Mostly I got the same result (nice job).
There was one curious difference. It seems to me that some keys produce a
pair of characters in the 0x06xx Unicode block (Arabic) in GNOME, for
example the B key produces 0x644 (ARABIC LETTER LAM), 0x627 (ARABIC LETTER
ALEF). Your map seems to use single character from block 0xFExx (Arabic
Presentation Forms B), in this example case 0xFEFB (ARABIC LIGATURE LAM WITH
ALEF ISOLATED FORM). Does this match the behavior of Arabic keyboard layout
in your OS?
Cheers,
Jiri
---------- Původní zpráva ----------
Od: MaaSTaaR <[email protected]>
Datum: 9. 12. 2012
Předmět: [HelenOS-devel] Arabic keyboard for HelenOS
"
Hello
I modified the layout file (us_qwerty.c) and create a new layout to support
Arabic keyboard in HelenOS. It seems to work fine with me. I attached the
patch file and the layout file ar.c (which is based on us_qwerty.c).
Sorry for any errors or mistakes it's my first time to sumbit a patch for
HelenOS. Sorry for my English also :-)
Regards,
Mohammed Q. Hussain.
"
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
