Hi MaaSTaaR, On 12/12/2012 10:05 AM, MaaSTaaR wrote: >> A small nit, as it seems Caps shift is not used on Arabic keyboard > (there is no upper/lower case), you changed map_ucase/map_lcase to > behave exactly like map_shifted / map_unshifted. It might be better just > to move the contents of map_ucase to map_shifted and map_lcase to > map_unshifted and remove map_ucase/map_lcase altogether. > > Done. I attached the modified file.
I integrated your changes as of mainline,1737. Thanks for contributing this and sorry for the delay; I was expecting Jiri to say his final LGTM, but the patch looks correct wrt. his comments anyway so I went ahead and applied it. Btw, pushing this change crashed Bazaar, producing the following message: bzr: ERROR: exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 20: ordinal not in range(128) Looks like Bazaar could not handle the newly added UTF8 characters. Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
