On 7 August 2013 14:53, Jakub Jermar <[email protected]> wrote: > On 7.8.2013 12:00, Jakub Jermar wrote: >> On 6.8.2013 20:35, Jiří Zárevúcky wrote: >>> You can check out the current state of my work at [0]. There are some >>> things that could use cleanup, and there may be unnoticed bugs and/or >>> memory leaks, but I am keeping the repository in a consistent state, so >>> it should build and work just like the current mainline tip. >>> >>> [0] https://code.launchpad.net/~zarevucky-jiri/helenos/vfs2-cherrypick >> >> I definitely plan to have a look as soon as my schedule permits. > > Ok, I apparently underestimated my curiosity. I like the way how your > changes remove lots of code and make things simpler. Hopefully your test > plan is equally advanced. >
Thanks. Testing is a tricky thing, since there is a lot of external influence, but writing down complete specification for every operation and then manually checking that the code matches can help a lot I think. Speaking of which, is there any proper specification of how IPC primitives behave? > How about the aoffs64_t vs. int64_t changes? Also, the type casts from > vfs_node_t * to vfs_triplet_t were a bit scary, but I guess these were > rather temporary workarounds. > I'd like to get rid of aoffs64_t and similar obscure types. Position is a 64-bit integer, and there is no point in hiding that fact behind a wall of crazy acronyms. As for the scary casts, yes, that is temporary. :) -- Jirka Z. _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
