Hello Wolf.

2014-04-29 13:53 GMT+02:00 Wolf Ramovsky <[email protected]>:

> Hello
>
> As you see, I've deployed code to show that I am able to set mode from
> uspace. I've tested it only on x86_32 qemu. Could you test it on other
> VM-s and real hardware?
>
I have tested it in QEMU and in VirtualBox. It does something :-)


Run "win.exe" in console. If you build HelenOS with GUI enabled, build
> with resolution different from 640x480x16 to be sure that mode is
> changed (since it's hardcoded to mentioned one).
>
> P.S. Debug build is broken due to warnings generated by libx86emu (and
> program, to be honest).
>
I would recommend you to fix the warnings ASAP. The more you postpone it,
the more work it would require afterwards.

Next, the code is not compilable at all ;-). Definition of NAME is missing.

Please, follow our coding style. For example, we place space between for
and the opening parenthesis.

And one more thing - your files miss a license block at the top.

Cheers!
- Vojta



>
> Thank you.
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/listinfo/helenos-devel
>
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to