Hello Wolf,

As you see, I've deployed code to show that I am able to set mode from
uspace. I've tested it only on x86_32 qemu. Could you test it on other
VM-s and real hardware?

I have tested your setmode branch successfully on the following (physical hardware):

 * Apple Mac Pro 4.1 (Early 2009) with nVidia GeForce GT 120
 * Apple Mac Pro 4.1 (Early 2009) with ATI Radeon 4850
 * Lenovo ThinkPad T410s with Intel HD Graphics (Arrandale)

In all cases the mode was set successfully. I can also confirm that it works in VirtualBox 4.3.6. I'll go on testing it on another hardware that I have access to, as my time permits.


Surprisingly, the mode setting code failed in my QEMU (in Fedora 19 and Fedora 20) with the following messages:

rdb: address unknown 0x00002fda
rdb: address unknown 0xc11e0000
Mode 0xc112 unsupported

I have checked and the VESA mode 0x112 is supported by the VESA BIOS in my QEMU (and works correctly if set by GRUB). Below is the list of the package versions if you would like to reproduce it (I'll try to look into it as well, again as time permits):

qemu-system-x86-1.6.2-4.fc20.x86_64
seavgabios-bin-1.7.3.1-2.fc20.noarch

qemu-system-x86-1.4.2-15.fc19.x86_64
seavgabios-bin-1.7.2.2-3.fc19.noarch

P.S. Debug build is broken due to warnings generated by libx86emu (and
program, to be honest).

While I totally understand that this is just a rough prototype, you should definitively follow Vojta's advice: Make sure the code is compliant to our coding style [1], it has all the necessary properties (license headers, etc.) and make sure it compiles fine with -Werror enabled. The compiler warnings should be dealt with, not ignored.

The more you postpone making your code nice, clean and readable, the larger technical debt [2] you create.

[1] http://trac.helenos.org/wiki/CStyle
[2] http://en.wikipedia.org/wiki/Technical_debt


M.D.

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to