Hello Wolf,
a few comments on your current code (please don't take it as criticism,
but rather as TODOs :)):
* I agree with the comments by Jiri Svoboda. Try to split the IPC code
from compctl into a module in libc, to make compctl more abstract and
the IPC stubs reusable.
* Also the command line of compctl can be make more intuitive, as Jiri
suggested.
* Please merge the mainline changes into your branch (and merge
frequently from mainline) to avoid divergence.
* Currently you have disabled kfb. Note that kfb needs to stay enabled
for two reasons:
a) kfb is used on non-ia32, non-amd64 platforms.
b) kfb should be still usable in case vesafb fails to initialize (for
any reason).
There needs to be some kind of hand-off between kfb and vesafb, both
drivers need to coexist side-by-side in a limited way.
* I know that this is not your idea, but the dual naming of the
compositor nodes (comp:0/* vs. comp/:0) is somewhat confusing. I
would really prefer creating the control node as for example
comp:0/ctrl.
* The solution with the separate thread in vesafb is not very elegant.
You should first initialize the hardware (port_init()) and only after
the initialization succeeds register the DDF function.
* There are still some tiny cstyle issues (lines starting with a space
in compctl.c, CamelCase in libvbe, lack of essential documentation
comments).
But generally your progress looks nice. I am looking forward to the
future development with even less rough edges.
M.D.
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
