Hi Sourav,

On 03/05/2017 07:47 PM, sourav punoriyar wrote:
> 2>copied boot_args to loaders local memory and then passed to kernel.

Thanks for continuing to improve your patch!

I noticed you attempt to copy out the boot args from bootinfo to a
kernel global variable (you should not define it in a .h file though).
I'd rather keep this in bootinfo and let the kernel read it from there.

At the same time, I think there has been a preexisting kernel bug in
code that uses bootinfo as I can't find or justify to myself how the
kernel guarantees it will not not overwrite it (in a similar way it
guarantees it won't overwrite ballocs). I will deal with this when I
come back from vacation.

Cheers,
Jakub

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to