Thanks Jakub.... I will remove the extra copy as it is not required .Kernel can read it directly from bootinfo. I will try to check the code to find some reasons on whether kernel guarantees it would not overwrite bootinfo,
Also i will look forward to second step to get serial working and studying more about HelenOS. Happy vacations :-) On Mon, Mar 6, 2017 at 12:25 PM, Jakub Jermář <[email protected]> wrote: > Hi Sourav, > > On 03/05/2017 07:47 PM, sourav punoriyar wrote: > > 2>copied boot_args to loaders local memory and then passed to kernel. > > Thanks for continuing to improve your patch! > > I noticed you attempt to copy out the boot args from bootinfo to a > kernel global variable (you should not define it in a .h file though). > I'd rather keep this in bootinfo and let the kernel read it from there. > > At the same time, I think there has been a preexisting kernel bug in > code that uses bootinfo as I can't find or justify to myself how the > kernel guarantees it will not not overwrite it (in a similar way it > guarantees it won't overwrite ballocs). I will deal with this when I > come back from vacation. > > Cheers, > Jakub > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/listinfo/helenos-devel > -- Regards, Sourav Punoriyar Bazaar identity: Sourav Punoriyar <sourav.punoriyar@spunor>
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
