Hi,

I was looking at the source of the Hippo Repository Java adapter and
noticed a few things:

- In the Javadoc of the WebdavService there is no notion of the
DocumentNotFoundException and CollectionNotFoundException
- Although it is not explicitly in the Javadoc, it seems that most of
the methods can not return null. Should this be more explicit?
- The NOPWebdavService returns null for most of its methods. Something
which is not possible with the real WebdavServiceImpl. Maybe throw
exceptions in the NOP implementation?
- I miss a FacetCollectionNotFoundException for the fetchFacets
methods. Are those Facets always found or will these methods return
null when nothing is found?

With regards,

Nick Stolwijk
~Java Developer~

Iprofs BV.
Claus Sluterweg 125
2012 WS Haarlem
www.iprofs.nl
********************************************
Hippocms-dev: Hippo CMS development public mailinglist

Searchable archives can be found at:
MarkMail: http://hippocms-dev.markmail.org
Nabble: http://www.nabble.com/Hippo-CMS-f26633.html

Reply via email to