Hi Nick, Nick Stolwijk wrote: > Hi, > > I was looking at the source of the Hippo Repository Java adapter and > noticed a few things: > > - In the Javadoc of the WebdavService there is no notion of the > DocumentNotFoundException and CollectionNotFoundException I guess the javadoc is a bit out of date :(
> - Although it is not explicitly in the Javadoc, it seems that most of > the methods can not return null. Should this be more explicit? If this is true, we certainly should mention it (and test for it). > - The NOPWebdavService returns null for most of its methods. Something > which is not possible with the real WebdavServiceImpl. Maybe throw > exceptions in the NOP implementation? I'm not too familiar with the NOPWebdavService. > - I miss a FacetCollectionNotFoundException for the fetchFacets > methods. Are those Facets always found or will these methods return > null when nothing is found? I do not complete agree. The DNFE and CNFE represent the absence of a resource a the given path (eg a '404'). The fetchFacets method is basically a /search/. If a search cannot find anything it should just return zero results or an empty collection, imo. Regards, Bart > > With regards, > > Nick Stolwijk > ~Java Developer~ > > Iprofs BV. > Claus Sluterweg 125 > 2012 WS Haarlem > www.iprofs.nl > ******************************************** > Hippocms-dev: Hippo CMS development public mailinglist > > Searchable archives can be found at: > MarkMail: http://hippocms-dev.markmail.org > Nabble: http://www.nabble.com/Hippo-CMS-f26633.html > -- Hippo B.V. - Amsterdam Oosteinde 11, 1017 WT, Amsterdam, +31(0)20-5224466 Hippo USA Inc. - San Francisco 101 H Street, Suite Q, Petaluma CA, 94952-3329, +1 (707) 773-4646 ----------------------------------------------------------------- http://www.onehippo.com - [EMAIL PROTECTED] ----------------------------------------------------------------- ******************************************** Hippocms-dev: Hippo CMS development public mailinglist Searchable archives can be found at: MarkMail: http://hippocms-dev.markmail.org Nabble: http://www.nabble.com/Hippo-CMS-f26633.html
