[
https://issues.apache.org/jira/browse/HIVE-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681131#action_12681131
]
Namit Jain commented on HIVE-309:
---------------------------------
Looks good - I had some minor comments:
Instead of making property file dependent on system property
org.apache.hadoop.hive.ql.exec.FunctionRegistry.propertyfile, would it be a
good idea to make it a
configurable parameter with the default being hive-udf.properties in the
configuration directory. The users can overwrite this file or add a new one
somewhere else,
and point to the new file.
Also, it would be great it you can add a dummy property file with some UDF and
UDAF for testing.
> FunctionRegistry should allow loading UDFs and UDAFs from property file
> -----------------------------------------------------------------------
>
> Key: HIVE-309
> URL: https://issues.apache.org/jira/browse/HIVE-309
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Richard Lee
> Attachments: hive-external-functions-2.diff,
> hive-external-functions.diff
>
>
> FunctionRegistry.java hard code all UDF, UDAF definitions in a static
> initializer. There is no way to add new functions without directly modifying
> this file.
> FunctionRegistry SHOULD look for a property file in which new functions and
> their implementations can be specified. This will allow third parties to
> extend hive without maintaining patches against the codebase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.