[ 
https://issues.apache.org/jira/browse/HIVE-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694288#action_12694288
 ] 

Namit Jain commented on HIVE-309:
---------------------------------

I got the following error while applying the patch:

[nj...@dev119 trunk]$ patch -p0 < /tmp/hive.309.patch 
(Stripping trailing CRs from patch.)
patching file build-common.xml
(Stripping trailing CRs from patch.)
patching file ql/src/test/results/clientpositive/udf_from_properties.q.out
(Stripping trailing CRs from patch.)
patching file ql/src/test/hive-udf.properties
(Stripping trailing CRs from patch.)
patching file ql/src/test/queries/clientpositive/udf_from_properties.q
(Stripping trailing CRs from patch.)
patching file ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
Hunk #3 FAILED at 159.
1 out of 3 hunks FAILED -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java.rej


Can you refresh and resubmit the patch ?

> FunctionRegistry should allow loading UDFs and UDAFs from property file
> -----------------------------------------------------------------------
>
>                 Key: HIVE-309
>                 URL: https://issues.apache.org/jira/browse/HIVE-309
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Richard Lee
>         Attachments: hive-external-functions-2.diff, 
> hive-external-functions.diff, hive-external-functions2.diff
>
>
> FunctionRegistry.java hard code all UDF, UDAF definitions in a static 
> initializer.  There is no way to add new functions without directly modifying 
> this file.  
> FunctionRegistry SHOULD look for a property file in which new functions and 
> their implementations can be specified.  This will allow third parties to 
> extend hive without maintaining patches against the codebase. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to