[
https://issues.apache.org/jira/browse/HIVE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734674#action_12734674
]
Namit Jain commented on HIVE-487:
---------------------------------
Overall, it looks good - but can you do a simple cosmetic changes.
1. Have 1 patch instead of different patches for jetty and 487
2. Add more comments:
/**
29 Hadoop 17-19 used Jetty5.
Hadoop 20 uses jetty6. Hive still should compile and
...run with all versions.
30 Java is strongly typed Class
based language. The Reflection API is required to
...circumvent the strong
31 typing. We have used the
reflection API to deal with the known versions of Jetty
...we must work with.
32 CS students: If you are ever
in a debate about classless VS classful programming
...be sure to
33 reference this code.
34 */
is very good:
Can you repeat a subset of this in HadoopVersion also ?
Hive still should compile and
...run with all versions. (17-20)
3. usesJobShell: can you add more comments here -- it is true for version 20
but not for 20 etc.
4. This may be outside the scope of this - but should some unit tests run for
hadoop17, and some for hadoop 20, as part of ant test.
Currently, all of them use the default 19. As I mentioned before, this can
be done in a follow-up also.
> Hive does not compile with Hadoop 0.20.0
> ----------------------------------------
>
> Key: HIVE-487
> URL: https://issues.apache.org/jira/browse/HIVE-487
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Aaron Kimball
> Assignee: Justin Lynn
> Fix For: 0.4.0
>
> Attachments: HIVE-487-2.patch, hive-487-jetty-2.diff,
> hive-487-jetty.patch, hive-487.3.patch, hive-487.4.patch, HIVE-487.patch,
> jetty-patch.patch, junit-patch1.html
>
>
> Attempting to compile Hive with Hadoop 0.20.0 fails:
> aa...@jargon:~/src/ext/svn/hive-0.3.0$ ant -Dhadoop.version=0.20.0 package
> (several lines elided)
> compile:
> [echo] Compiling: hive
> [javac] Compiling 261 source files to
> /home/aaron/src/ext/svn/hive-0.3.0/build/ql/classes
> [javac]
> /home/aaron/src/ext/svn/hive-0.3.0/build/ql/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java:94:
> cannot find symbol
> [javac] symbol : method getCommandLineConfig()
> [javac] location: class org.apache.hadoop.mapred.JobClient
> [javac] Configuration commandConf =
> JobClient.getCommandLineConfig();
> [javac] ^
> [javac]
> /home/aaron/src/ext/svn/hive-0.3.0/build/ql/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:241:
> cannot find symbol
> [javac] symbol : method validateInput(org.apache.hadoop.mapred.JobConf)
> [javac] location: interface org.apache.hadoop.mapred.InputFormat
> [javac] inputFormat.validateInput(newjob);
> [javac] ^
> [javac] Note: Some input files use or override a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 2 errors
> BUILD FAILED
> /home/aaron/src/ext/svn/hive-0.3.0/build.xml:145: The following error
> occurred while executing this line:
> /home/aaron/src/ext/svn/hive-0.3.0/ql/build.xml:135: Compile failed; see the
> compiler error output for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
