[ 
https://issues.apache.org/jira/browse/HIVE-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795650#action_12795650
 ] 

Bill Jia commented on HIVE-894:
-------------------------------

The new codes are based on UDAFExampleAvg.java. So I assume that the standard 
apache header is kept. Let me know if it is not the case and where I can find 
the header. 

Sure - I can share the codes. I wonder in what format and by what means I can 
share.

I probably need some instruction on how to add tests to described extended 
max_n/min_n. I added udaf_example_max_n.q and udaf_example_min_n.q. Should I 
add more tests like these?



> add udaf max_n, min_n to contrib
> --------------------------------
>
>                 Key: HIVE-894
>                 URL: https://issues.apache.org/jira/browse/HIVE-894
>             Project: Hadoop Hive
>          Issue Type: New Feature
>            Reporter: Zheng Shao
>            Assignee: Bill Jia
>         Attachments: HIVE-894.1.patch
>
>
> These 2 UDAFs should return the max n numbers, min n numbers in order.
> {code}
> SELECT max_n(userid, 3) FROM src;
> [999,997,996]
> SELECT max_n(userid, 3)[1] FROM src;
> 997
> SELECT min_n(userid, 3) FROM src;
> [0, 3, 8]
> SELECT min_n(userid, 3)[2] FROM src;
> 8
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to