[ 
https://issues.apache.org/jira/browse/HIVE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838135#action_12838135
 ] 

Zheng Shao commented on HIVE-259:
---------------------------------

1. We are converting "25,50,99" to ArrayList<Integer>. Why don't we directly 
accept an int array (or a double array to allow 99.9).

In the query, the user can say:

SELECT percentile(mycol, array(25, 50, 99) FROM mytable;

2. Get rid of State.initDone.  We can set "ArrayList<Integer> percentiles" to 
null first. That saves some space in memory as well as network when we transfer 
the state from mapper to reducer.

3. In Java, variable names should be lowercased.

4. We should change the test case to be non-trivial.


> Add PERCENTILE aggregate function
> ---------------------------------
>
>                 Key: HIVE-259
>                 URL: https://issues.apache.org/jira/browse/HIVE-259
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Venky Iyer
>            Assignee: Jerome Boulon
>         Attachments: HIVE-259-2.patch, HIVE-259.1.patch, HIVE-259.patch, 
> jb2.txt, Percentile.xlsx
>
>
> Compute atleast 25, 50, 75th percentiles

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to