[
https://issues.apache.org/jira/browse/HIVE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839391#action_12839391
]
He Yongqiang commented on HIVE-259:
-----------------------------------
The code looks very good. Thanks for the code work, Jerome and Zheng!
Just some minor comments:
(1) I am not familiar with the exact definition of percentile function. Is the
percentile()'s result must be a member of input data?
(2) HashMap and ArrayList is used to copy and sort. Can we use tree map here?
this is a small and can be ignored.
In the beginning of new test case,
DESCRIBE FUNCTION percentile;
DESCRIBE FUNCTION EXTENDED percentile;
appears two times.
And this is a very good function to have, it will be great if we can update its
usage to the wiki page or somewhere.
> Add PERCENTILE aggregate function
> ---------------------------------
>
> Key: HIVE-259
> URL: https://issues.apache.org/jira/browse/HIVE-259
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Venky Iyer
> Assignee: Jerome Boulon
> Attachments: HIVE-259-2.patch, HIVE-259-3.patch, HIVE-259.1.patch,
> HIVE-259.4.patch, HIVE-259.patch, jb2.txt, Percentile.xlsx
>
>
> Compute atleast 25, 50, 75th percentiles
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
