[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901641#action_12901641 ]
John Sichi commented on HIVE-1546: ---------------------------------- I have published some review comments here: http://review.cloudera.org/r/713/ In addition: * We need a test for loading a variation on the default semantic analyzer in order to exercise the pluggable configuration. You can create a subclass of the default analyzer (under ql/src/test/org/apache/hadoop/hive/ql/parse) to inject some mock behavior change. * We need a test for the new INPUTDRIVER/OUTPUTDRIVER clauses. Otherwise, people will wonder why they're in the grammar but not referenced elsewhere in Hive; the test will give you a chance to explain the Howl dependency. * We need a negative test for unrecognized generic format. Let me know if you need help with how to script new positive+negative test cases. (BTW, your patch file header had a glitch in it; we usually use svn diff format.) > Ability to plug custom Semantic Analyzers for Hive Grammar > ---------------------------------------------------------- > > Key: HIVE-1546 > URL: https://issues.apache.org/jira/browse/HIVE-1546 > Project: Hadoop Hive > Issue Type: Improvement > Components: Metastore > Affects Versions: 0.7.0 > Reporter: Ashutosh Chauhan > Assignee: Ashutosh Chauhan > Fix For: 0.7.0 > > Attachments: hive-1546.patch > > > It will be useful if Semantic Analysis phase is made pluggable such that > other projects can do custom analysis of hive queries before doing metastore > operations on them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.