[
https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated HIVE-1546:
-----------------------------------
Attachment: hive-1546_2.patch
Attaching a new patch.
bq. In addition, I think we should introduce a new interface
HiveSemanticAnalyzer and have the factory produce that, since factories should
generally produce interfaces rather than classes (e.g. so that dynamic proxies
can be used).
This got me thinking and I have redesigned the patch, so now we have factory
producing factory enabling dynamic proxying (abstractions and extensibility !)
Your other comments got affected by it because of it but I have taken care of
them.
Signature for method handleGenricFileFormat() was String[] because description
for task and task itself is created in analyzeCreateTable() and
analyzeTableFileFormat() so that method cant be void, as it needs to return
whatever information it gathered to its calling method. Since at present we
have no such file format, return value is ignored by calling methods. However I
changed it to Map<String,String> because that seems more useful then String[].
Added test-cases for all three cases you suggested.
> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>
> Key: HIVE-1546
> URL: https://issues.apache.org/jira/browse/HIVE-1546
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Metastore
> Affects Versions: 0.7.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.7.0
>
> Attachments: hive-1546.patch, hive-1546_2.patch
>
>
> It will be useful if Semantic Analysis phase is made pluggable such that
> other projects can do custom analysis of hive queries before doing metastore
> operations on them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
