[
https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917677#action_12917677
]
Namit Jain commented on HIVE-1546:
----------------------------------
I will take a look in more detail, but overall it looks good. I had the
following comments:
1. Instead of TestSemanticAnalyzerHookLoading.java, add tests in
test/queries/clientpositive and test/queries/clientnegative
2. Do you want to set the value of hive.semantic.analyzer.hook to a dummy value
in data/conf/hive-site.xml for the unit tests ?
Can something meaningful be printed here, which can be used for comparing ?
> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>
> Key: HIVE-1546
> URL: https://issues.apache.org/jira/browse/HIVE-1546
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Metastore
> Affects Versions: 0.7.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.7.0
>
> Attachments: hive-1546-3.patch, hive-1546-4.patch, hive-1546.patch,
> hive-1546_2.patch, hooks.patch, Howl_Semantic_Analysis.txt
>
>
> It will be useful if Semantic Analysis phase is made pluggable such that
> other projects can do custom analysis of hive queries before doing metastore
> operations on them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
