[ 
https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917851#action_12917851
 ] 

Ashutosh Chauhan commented on HIVE-1546:
----------------------------------------

I did it in junit form because John suggested it that way in his earlier 
comment:

{quote}
    * We need a test for loading a variation on the default semantic analyzer 
in order to exercise the pluggable configuration. You can create a subclass of 
the default analyzer (under ql/src/test/org/apache/hadoop/hive/ql/parse) to 
inject some mock behavior change.
{quote}

I also feel junit test is better suited for this kind of behavioral testing of 
code paths (which exercises interface points) rather then forcing through 
string comparison ways of test/queries/*  which are more end-to-end tests for 
hive. Further if we add dummy hook name in data/conf/hive-site.xml then that 
dummy hook will get loaded and all the subsequent tests will have it too. Do we 
want it that way?

> Ability to plug custom Semantic Analyzers for Hive Grammar
> ----------------------------------------------------------
>
>                 Key: HIVE-1546
>                 URL: https://issues.apache.org/jira/browse/HIVE-1546
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.7.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: hive-1546-3.patch, hive-1546-4.patch, hive-1546.patch, 
> hive-1546_2.patch, hooks.patch, Howl_Semantic_Analysis.txt
>
>
> It will be useful if Semantic Analysis phase is made pluggable such that 
> other projects can do custom analysis of hive queries before doing metastore 
> operations on them. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to